Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(db_api): raise exception with message for executemany() #595

Merged
merged 11 commits into from Nov 16, 2021

Conversation

IlyaFaer
Copy link
Member

@IlyaFaer IlyaFaer commented Sep 28, 2021

While working on tests for SQLAlchemy 1.4 I've noticed that using details in executemany() is not efficient - looking at them, it's hard to understand what actually gone wrong. It's better to use message property.

Relates to batch_update() method results.

@IlyaFaer IlyaFaer added api: spanner type: feature request labels Sep 28, 2021
@google-cla google-cla bot added the cla: yes label Sep 28, 2021
@IlyaFaer IlyaFaer requested a review from larkee Sep 28, 2021
@IlyaFaer IlyaFaer marked this pull request as ready for review Sep 28, 2021
@IlyaFaer IlyaFaer requested a review from as a code owner Sep 28, 2021
larkee
larkee approved these changes Oct 13, 2021
@IlyaFaer IlyaFaer added the kokoro:force-run label Oct 15, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Oct 15, 2021
@IlyaFaer IlyaFaer requested a review from as a code owner Oct 25, 2021
@IlyaFaer IlyaFaer merged commit 95908f6 into googleapis:main Nov 16, 2021
13 checks passed
@IlyaFaer IlyaFaer deleted the error_msg branch Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner cla: yes type: feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants