Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(db_api): support JSON data type #627

Merged
merged 13 commits into from
Nov 22, 2021
Merged

feat(db_api): support JSON data type #627

merged 13 commits into from
Nov 22, 2021

Conversation

IlyaFaer
Copy link
Contributor

No description provided.

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 18, 2021
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner API. label Oct 18, 2021
@IlyaFaer IlyaFaer marked this pull request as ready for review October 18, 2021 10:29
@IlyaFaer IlyaFaer requested a review from a team as a code owner October 18, 2021 10:29
@IlyaFaer IlyaFaer mentioned this pull request Oct 19, 2021
Merged
@IlyaFaer IlyaFaer requested a review from a team as a code owner October 25, 2021 10:54
@larkee larkee added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 28, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 28, 2021
@larkee larkee added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 29, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 29, 2021
@larkee larkee added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 30, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 30, 2021
@larkee larkee added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 31, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 31, 2021
@larkee
Copy link
Contributor

larkee commented Nov 1, 2021

@IlyaFaer There are system test and sample failures relating to JSON comparisons because the assertions are expecting a JSON string but are getting a Python dict. This can be fixed by overriding the __repr__ method on JsonObject to return self.serialize().

@IlyaFaer IlyaFaer requested a review from a team as a code owner November 1, 2021 09:18
@IlyaFaer IlyaFaer requested a review from nicain November 1, 2021 09:18
@larkee larkee changed the title feat: support JSON data type feat(dbapi): support JSON data type Nov 1, 2021
@larkee larkee changed the title feat(dbapi): support JSON data type feat(db_api): support JSON data type Nov 1, 2021
@IlyaFaer IlyaFaer added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 2, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 2, 2021
@larkee
Copy link
Contributor

larkee commented Nov 19, 2021

@IlyaFaer There are lint errors and the sample assertions are still failing.

@IlyaFaer
Copy link
Contributor Author

@larkee, oh, looks like some samples requires some work. Working on it...

@IlyaFaer
Copy link
Contributor Author

@larkee, this one seems to be okay for merge.

@skuruppu skuruppu merged commit d760c2c into googleapis:main Nov 22, 2021
@IlyaFaer IlyaFaer deleted the json_type branch November 23, 2021 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larkee larkee larkee approved these changes

@skuruppu skuruppu Awaiting requested review from skuruppu

@nicain nicain Awaiting requested review from nicain nicain was automatically assigned from googleapis/python-samples-owners

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/python-spanner API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@IlyaFaer @larkee @skuruppu @yoshi-kokoro