Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(db_api): support JSON data type #627

Merged
merged 13 commits into from Nov 22, 2021
Merged

feat(db_api): support JSON data type #627

merged 13 commits into from Nov 22, 2021

Conversation

@IlyaFaer
Copy link
Member

@IlyaFaer IlyaFaer commented Oct 18, 2021

No description provided.

@google-cla google-cla bot added the cla: yes label Oct 18, 2021
@IlyaFaer IlyaFaer requested review from larkee and skuruppu Oct 18, 2021
@IlyaFaer IlyaFaer marked this pull request as ready for review Oct 18, 2021
@IlyaFaer IlyaFaer requested a review from as a code owner Oct 18, 2021
larkee
larkee approved these changes Oct 21, 2021
@IlyaFaer IlyaFaer requested a review from as a code owner Oct 25, 2021
@larkee
Copy link
Contributor

@larkee larkee commented Nov 1, 2021

@IlyaFaer There are system test and sample failures relating to JSON comparisons because the assertions are expecting a JSON string but are getting a Python dict. This can be fixed by overriding the __repr__ method on JsonObject to return self.serialize().

@IlyaFaer IlyaFaer requested a review from as a code owner Nov 1, 2021
@IlyaFaer IlyaFaer requested a review from nicain (assigned from googleapis/python-samples-owners) Nov 1, 2021
@larkee larkee changed the title feat: support JSON data type feat(dbapi): support JSON data type Nov 1, 2021
@larkee larkee changed the title feat(dbapi): support JSON data type feat(db_api): support JSON data type Nov 1, 2021
@larkee
Copy link
Contributor

@larkee larkee commented Nov 19, 2021

@IlyaFaer There are lint errors and the sample assertions are still failing.

@IlyaFaer
Copy link
Member Author

@IlyaFaer IlyaFaer commented Nov 19, 2021

@larkee, oh, looks like some samples requires some work. Working on it...

@IlyaFaer
Copy link
Member Author

@IlyaFaer IlyaFaer commented Nov 22, 2021

@larkee, this one seems to be okay for merge.

@skuruppu skuruppu merged commit d760c2c into googleapis:main Nov 22, 2021
13 checks passed
@IlyaFaer IlyaFaer deleted the json_type branch Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants