Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(db_api): emit warning instead of an exception for rowcount property #628

Merged
merged 4 commits into from Oct 26, 2021

Conversation

@IlyaFaer
Copy link
Member

@IlyaFaer IlyaFaer commented Oct 19, 2021

See for more context: googleapis/python-spanner-sqlalchemy#134

@google-cla google-cla bot added the cla: yes label Oct 19, 2021
@IlyaFaer IlyaFaer requested review from larkee and skuruppu Oct 19, 2021
@IlyaFaer IlyaFaer marked this pull request as ready for review Oct 19, 2021
@IlyaFaer IlyaFaer requested a review from as a code owner Oct 19, 2021
@larkee larkee changed the title feat: emit warning instead of an exception for rowcount property fix: emit warning instead of an exception for rowcount property Oct 21, 2021
@larkee larkee changed the title fix: emit warning instead of an exception for rowcount property fix(db_api): emit warning instead of an exception for rowcount property Oct 21, 2021
larkee
larkee approved these changes Oct 21, 2021
@IlyaFaer
Copy link
Member Author

@IlyaFaer IlyaFaer commented Oct 21, 2021

@larkee, only samples failed with timeout errors, not related. I guess your admin access could finish the job here (not to hold off another related PR).

@gcf-merge-on-green
Copy link
Contributor

@gcf-merge-on-green gcf-merge-on-green bot commented Oct 21, 2021

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@IlyaFaer IlyaFaer requested a review from as a code owner Oct 25, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 62ff9ae into googleapis:main Oct 26, 2021
13 checks passed
@IlyaFaer IlyaFaer deleted the exception_to_warn branch Oct 26, 2021
asthamohta added a commit to asthamohta/python-spanner that referenced this issue Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants