Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Django and SQLAlchemy APIs are failing to use rowcount #654

Merged
merged 3 commits into from Jan 6, 2022

Conversation

IlyaFaer
Copy link
Member

@IlyaFaer IlyaFaer commented Dec 24, 2021

@IlyaFaer IlyaFaer added the type: bug label Dec 24, 2021
@product-auto-label product-auto-label bot added the api: spanner label Dec 24, 2021
@IlyaFaer IlyaFaer requested review from skuruppu and larkee Dec 24, 2021
@IlyaFaer IlyaFaer marked this pull request as ready for review Dec 24, 2021
@IlyaFaer IlyaFaer requested review from as code owners Dec 24, 2021
@skuruppu skuruppu requested a review from vi3k6i5 Dec 29, 2021
vi3k6i5
vi3k6i5 approved these changes Jan 5, 2022
Copy link
Contributor

@vi3k6i5 vi3k6i5 left a comment

LGTM, this will fix a lot of open issues in django and SQLAlchemy.

@vi3k6i5 vi3k6i5 added the kokoro:force-run label Jan 5, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Jan 5, 2022
@vi3k6i5 vi3k6i5 merged commit 698260e into googleapis:main Jan 6, 2022
13 checks passed
@IlyaFaer IlyaFaer deleted the rowcount branch Jan 6, 2022
vi3k6i5 added a commit to vi3k6i5/python-spanner that referenced this issue Mar 29, 2022
…is#654)

* fix: Django and SQLAlchemy APIs are failing to use rowcount

* lint fix

Co-authored-by: Vikash Singh <3116482+vi3k6i5@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants