Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update batch-usage reflect the correct usage #93

Merged
merged 3 commits into from Jun 4, 2020

Conversation

larkee
Copy link
Contributor

@larkee larkee commented Jun 4, 2020

The documentation incorrectly stated that database.batch() would return a Batch object. The recommended way to get a Batch object is to use the BatchCheckout as a context manager in a with statement. The documentation has been update to reflect this.

Documentation links and minor grammar fixes are also included.

@larkee larkee requested review from hengfengli and skuruppu Jun 4, 2020
@googlebot googlebot added the cla: yes label Jun 4, 2020
docs/batch-usage.rst Outdated Show resolved Hide resolved
Copy link

@hengfengli hengfengli left a comment

LGTM. 👍

@larkee larkee added the automerge label Jun 4, 2020
@gcf-merge-on-green
Copy link
Contributor

@gcf-merge-on-green gcf-merge-on-green bot commented Jun 4, 2020

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

1 similar comment
@gcf-merge-on-green
Copy link
Contributor

@gcf-merge-on-green gcf-merge-on-green bot commented Jun 4, 2020

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

@gcf-merge-on-green
Copy link
Contributor

@gcf-merge-on-green gcf-merge-on-green bot commented Jun 4, 2020

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@larkee larkee added the kokoro:force-run label Jun 4, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Jun 4, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit 6ec64d8 into googleapis:master Jun 4, 2020
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants