Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds model adaptation sample #121

Merged

Conversation

b-loved-dreamer
Copy link
Contributor

@b-loved-dreamer b-loved-dreamer commented Mar 12, 2021

This new sample shows how to create custom classes and phrase sets which are used for speech adaptation

@b-loved-dreamer b-loved-dreamer requested review from sirtorry, telpirion and a team as code owners Mar 12, 2021
@product-auto-label product-auto-label bot added the api: speech Issues related to the googleapis/python-speech API. label Mar 12, 2021
@snippet-bot
Copy link

snippet-bot bot commented Mar 12, 2021

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Mar 12, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 12, 2021
samples/microphone/README.rst Outdated Show resolved Hide resolved
samples/snippets/README.rst Outdated Show resolved Hide resolved
samples/snippets/speech_model_adaptation_beta.py Outdated Show resolved Hide resolved
samples/snippets/speech_model_adaptation_beta.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@busunkim96 busunkim96 left a comment

I didn't notice the first time, but the test file name needs to either start with test_ or end with _test for pytest to treat it as a test. It looks like it is being skipped right now.

samples/snippets/speech_model_adaptation_beta.py Outdated Show resolved Hide resolved
samples/snippets/speech_model_adaptation_beta.py Outdated Show resolved Hide resolved
samples/snippets/speech_model_adaptation_test_beta.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@busunkim96 busunkim96 left a comment

Tests are expected to setup/cleanup any resources. https://github.com/GoogleCloudPlatform/python-docs-samples/blob/89e67bcb655ed6d120dee46d2d40d866f7c72a59/storage/cloud-client/acl_test.py#L59-L65 has a good example of this.

If you need help fixing the test, please grab some time on my calendar next week.

samples/snippets/speech_model_adaptation_beta.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@busunkim96 busunkim96 left a comment

Thank you for making all those changes! The tests and sample LGTM. Please delete samples/snippets/speech_model_adaptation_test_beta.py before merging.

@@ -0,0 +1,21 @@
# Copyright 2021 Google LLC
Copy link
Collaborator

@busunkim96 busunkim96 Mar 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please delete this file.

Copy link
Contributor Author

@b-loved-dreamer b-loved-dreamer Mar 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File deleted.

@b-loved-dreamer b-loved-dreamer merged commit 24b9424 into googleapis:master Mar 15, 2021
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: speech Issues related to the googleapis/python-speech API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants