Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(samples): remove io dependency in transcribe samples #223

Merged
merged 6 commits into from Aug 10, 2021

Conversation

nicain
Copy link
Contributor

@nicain nicain commented Aug 9, 2021

  • Refactor transcribe samples (transcribe_async) into two separate samples (transcribe_async_file and transcribe_async_gcs).
  • Remove dependency on io module (use open instead of io.open).
  • Fix small issue in argparse config for samples Remove CLI interface for the samples.
  • Update tests.

runner.sh:

set -e

ROOT='python-speech'

pytest ${ROOT?}/samples/snippets/transcribe_async_gcs_test.py
pytest ${ROOT?}/samples/snippets/transcribe_async_file_test.py

@snippet-bot
Copy link

snippet-bot bot commented Aug 9, 2021

Here is the summary of changes.

You are about to add 4 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added api: speech Issues related to the googleapis/python-speech API. samples Issues that are directly related to samples. labels Aug 9, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 9, 2021
…l-file vs gcs) and remove io dependency. Refactor tests.
@telpirion telpirion changed the title Remove io dependency in transcribe samples fix: remove io dependency in transcribe samples Aug 9, 2021
Copy link
Contributor

@telpirion telpirion left a comment

Left a handful of comments.

samples/snippets/transcribe_async_gcs.py Outdated Show resolved Hide resolved
samples/snippets/transcribe_async_gcs.py Show resolved Hide resolved
samples/snippets/transcribe_async_gcs.py Outdated Show resolved Hide resolved
@parthea parthea changed the title fix: remove io dependency in transcribe samples docs(samples): remove io dependency in transcribe samples Aug 9, 2021
@nicain nicain requested a review from telpirion Aug 9, 2021
samples/snippets/transcribe_async_file.py Outdated Show resolved Hide resolved
samples/snippets/transcribe_async_file.py Outdated Show resolved Hide resolved
samples/snippets/transcribe_async_file_test.py Outdated Show resolved Hide resolved
samples/snippets/transcribe_async_gcs.py Outdated Show resolved Hide resolved
@nicain nicain marked this pull request as ready for review Aug 10, 2021
@nicain nicain merged commit 928ca3a into googleapis:master Aug 10, 2021
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: speech Issues related to the googleapis/python-speech API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants