Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: migrate to microgenerator #61

Merged
merged 8 commits into from Sep 24, 2020
Merged

feat!: migrate to microgenerator #61

merged 8 commits into from Sep 24, 2020

Conversation

busunkim96
Copy link
Collaborator

@busunkim96 busunkim96 commented Sep 23, 2020

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 23, 2020
@busunkim96 busunkim96 marked this pull request as ready for review Sep 23, 2020
@product-auto-label product-auto-label bot added the api: speech Issues related to the googleapis/python-speech API. label Sep 23, 2020
google/cloud/speech_v1/helpers.py Show resolved Hide resolved
yield self.types.StreamingRecognizeRequest(streaming_config=config)
# yield a dictionary rather than the request object since the helper
# is used by both the v1 and v1p1beta1
yield {"streaming_config": config}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clever!

@busunkim96 busunkim96 added the automerge Merge the pull request once unit tests and other checks pass. label Sep 24, 2020
@busunkim96 busunkim96 merged commit 283b49d into master Sep 24, 2020
7 checks passed
@busunkim96 busunkim96 deleted the microgen branch Sep 24, 2020
@release-please release-please bot mentioned this pull request Sep 24, 2020
gcf-merge-on-green bot pushed a commit that referenced this pull request Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: speech Issues related to the googleapis/python-speech API. automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants