Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: migrated samples to speech 2.0.0 #78

Merged
merged 8 commits into from Oct 12, 2020

Conversation

b-loved-dreamer
Copy link
Contributor

@b-loved-dreamer b-loved-dreamer commented Oct 2, 2020

Started updating samples

@b-loved-dreamer b-loved-dreamer requested review from sirtorry, telpirion and a team as code owners Oct 2, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 2, 2020
@busunkim96
Copy link
Collaborator

busunkim96 commented Oct 2, 2020

Hmm, it looks like some of these already exist on master. Could you rebase your branch locally?

git checkout master
git pull origin master
git checkout speechmigration
git rebase master

@leahecole
Copy link
Contributor

leahecole commented Oct 2, 2020

I'm working with him now over chat to do a rebase :)

…mitations on local files for the long_running_recognize
…mitations on local files for the long_running_recognize
…ime limitations on local files for the long_running_recognize
… time limitations on local files for the long_running_recognize
@leahecole leahecole added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 5, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 5, 2020
@telpirion telpirion requested a review from tmatsuo Oct 7, 2020
tmatsuo
tmatsuo approved these changes Oct 8, 2020
Copy link
Member

@tmatsuo tmatsuo left a comment

LGTM

However, maybe it's easier to review if you separate the quote changes and the migration. Maybe next time.

@b-loved-dreamer
Copy link
Contributor Author

b-loved-dreamer commented Oct 9, 2020

@sirtorry, would you please review this PR.

@b-loved-dreamer b-loved-dreamer merged commit 47dd992 into googleapis:master Oct 12, 2020
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants