Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deleted a line duplicating the call to the recognizer #83

Merged
merged 12 commits into from Nov 16, 2020

Conversation

b-loved-dreamer
Copy link
Contributor

@b-loved-dreamer b-loved-dreamer commented Oct 28, 2020

Pushing this change to fix a duplicate issue

@b-loved-dreamer b-loved-dreamer requested review from sirtorry, telpirion and a team as code owners Oct 28, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 28, 2020
…mitations on local files for the long_running_recognize
…mitations on local files for the long_running_recognize
…ime limitations on local files for the long_running_recognize
… time limitations on local files for the long_running_recognize
tseaver
tseaver previously requested changes Oct 28, 2020
Copy link
Contributor

@tseaver tseaver left a comment

Please reduce the contents of this PR to those relevant to the changes you want to make. We require that submitted code pass our linter, including having no changes when black is run using our configuration.

samples/microphone/transcribe_streaming_infinite.py Outdated Show resolved Hide resolved
samples/microphone/transcribe_streaming_infinite.py Outdated Show resolved Hide resolved
samples/microphone/transcribe_streaming_infinite.py Outdated Show resolved Hide resolved
samples/microphone/transcribe_streaming_infinite.py Outdated Show resolved Hide resolved
samples/microphone/transcribe_streaming_infinite.py Outdated Show resolved Hide resolved
samples/microphone/transcribe_streaming_infinite.py Outdated Show resolved Hide resolved
samples/microphone/transcribe_streaming_infinite.py Outdated Show resolved Hide resolved
Copy link
Contributor

@telpirion telpirion left a comment

LGTM, pending all reviewer changes.

@b-loved-dreamer
Copy link
Contributor Author

b-loved-dreamer commented Oct 30, 2020

Hi @tseaver, I've resolved all those issues. All checks have now passed. Hi @sirtorry, would you please review this.

@telpirion telpirion dismissed tseaver’s stale review Nov 16, 2020

Reviewer has not responded to request for re-review.

@b-loved-dreamer b-loved-dreamer merged commit 3ef6ce5 into googleapis:master Nov 16, 2020
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants