Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds new multi region sample #96

Merged
merged 33 commits into from Dec 15, 2020

Conversation

b-loved-dreamer
Copy link
Contributor

@b-loved-dreamer b-loved-dreamer commented Dec 15, 2020

This new sample shows how to provide an endpoint to the speech service

b-loved-dreamer and others added 9 commits Nov 20, 2020
…mitations on local files for the long_running_recognize
…mitations on local files for the long_running_recognize
…ime limitations on local files for the long_running_recognize
… time limitations on local files for the long_running_recognize
    pick f510e8f chore: I updated the comments on the transcribe_async file to reflect time limitations on local files for the long_running_recognize
@snippet-bot
Copy link

snippet-bot bot commented Dec 15, 2020

Here is the summary of changes.

You added 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added api: speech Issues related to the googleapis/python-speech API. samples Issues that are directly related to samples. labels Dec 15, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 15, 2020
from google.cloud import speech
from google.api_core import client_options

# [END speech_python_migration_imports]
Copy link
Contributor

@telpirion telpirion Dec 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove--we only need these in the actual quickstart.

# limitations under the License.


def run_multi_region():
Copy link
Contributor

@telpirion telpirion Dec 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rename this. We usually try to give functions names that are a bit more descriptive.

Maybe try transcribe_with_multi_region?

# [END speech_multi_region]


if __name__ == "__main__":
Copy link
Contributor

@telpirion telpirion Dec 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove. We're moving towards a paradigm where Python samples aren't CLI runnable.


# [END speech_recognize_with_profanity_filter_gcs]

if __name__ == "__main__":
Copy link
Contributor

@telpirion telpirion Dec 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove this. The team is moving away from CLI presentation of samples.

@b-loved-dreamer b-loved-dreamer requested a review from a team as a code owner Dec 15, 2020
@b-loved-dreamer b-loved-dreamer merged commit a103f09 into googleapis:master Dec 15, 2020
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: speech Issues related to the googleapis/python-speech API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants