diff --git a/google/cloud/storage/acl.py b/google/cloud/storage/acl.py index 4458966ce..1ca78f258 100644 --- a/google/cloud/storage/acl.py +++ b/google/cloud/storage/acl.py @@ -137,7 +137,6 @@ class ACL(object): # Subclasses must override to provide these attributes (typically, # as properties). - client = None reload_path = None save_path = None user_project = None diff --git a/google/cloud/storage/client.py b/google/cloud/storage/client.py index 7df60c306..bec5da9a3 100644 --- a/google/cloud/storage/client.py +++ b/google/cloud/storage/client.py @@ -147,7 +147,7 @@ def __init__( kw_args["api_endpoint"] = storage_host if _is_emulator_set else None if client_options: - if type(client_options) == dict: + if isinstance(client_options, dict): client_options = google.api_core.client_options.from_dict( client_options ) diff --git a/tests/unit/test_transfer_manager.py b/tests/unit/test_transfer_manager.py index bdfd236b5..685f48579 100644 --- a/tests/unit/test_transfer_manager.py +++ b/tests/unit/test_transfer_manager.py @@ -192,7 +192,7 @@ def test_upload_many_suppresses_412_with_skip_if_exists(): worker_type=transfer_manager.THREAD, ) for result in results: - assert type(result) == exceptions.PreconditionFailed + assert isinstance(result, exceptions.PreconditionFailed) def test_upload_many_with_processes():