Skip to content
Permalink
Browse files
docs: revise docstrings for generate_signed_url (#408)
* Adjusting comment for accuracy

The assumed property is `signer_email` and not `service_account_email`.
In nowhere a property called `service_account_email` is read from `credentials`, but `signer_email` is.

* fix: adjusting comment for accuracy

The assumed property is `signer_email` and not `service_account_email`.
In nowhere a property called `service_account_email` is read from `credentials`, but `signer_email` is.

Co-authored-by: cojenco <59401799+cojenco@users.noreply.github.com>
  • Loading branch information
DiegoQueiroz and cojenco committed Apr 19, 2021
1 parent 412ce0b commit f090548437142b635191e90dcee1acd4c38e565c
Showing with 2 additions and 2 deletions.
  1. +2 −2 google/cloud/storage/_signing.py
@@ -277,7 +277,7 @@ def generate_signed_url_v2(
Assumes ``credentials`` implements the
:class:`google.auth.credentials.Signing` interface. Also assumes
``credentials`` has a ``service_account_email`` property which
``credentials`` has a ``signer_email`` property which
identifies the credentials.
.. note::
@@ -441,7 +441,7 @@ def generate_signed_url_v4(
Assumes ``credentials`` implements the
:class:`google.auth.credentials.Signing` interface. Also assumes
``credentials`` has a ``service_account_email`` property which
``credentials`` has a ``signer_email`` property which
identifies the credentials.
.. note::

0 comments on commit f090548

Please sign in to comment.