Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use converted expiration parameter for signed_query_params to generate_signed_url_v2 #105

Closed
HemangChothani opened this issue Apr 13, 2020 · 2 comments

Comments

@HemangChothani
Copy link
Contributor

@HemangChothani HemangChothani commented Apr 13, 2020

Issue created from the comment googleapis/google-cloud-python#9889 (comment)

suspected line of code.

"Expires": str(expiration),

/cc @frankyn

@frankyn
Copy link
Member

@frankyn frankyn commented Apr 13, 2020

Should be number of seconds since epoch instead of a strict conversion from int to str type: https://cloud.google.com/storage/docs/access-control/signed-urls-v2

Could you send a PR to fix this @HemangChothani?

@HemangChothani
Copy link
Contributor Author

@HemangChothani HemangChothani commented Apr 14, 2020

@frankyn Yes, for sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants