Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Blob.custom_time' setter doesnt update '_changes' #322

Closed
tamir-jether opened this issue Nov 22, 2020 · 0 comments
Closed

'Blob.custom_time' setter doesnt update '_changes' #322

tamir-jether opened this issue Nov 22, 2020 · 0 comments

Comments

@tamir-jether
Copy link

@tamir-jether tamir-jether commented Nov 22, 2020

i think the custom_time setter code should be:

        self._patch_property('customTime', value)

instead of

        self._properties["customTime"] = value
haim0n pushed a commit to haim0n/python-storage that referenced this issue Nov 22, 2020
This way '_PropertyMixin.patch' will send them to server.
Fixes googleapis#322
haim0n added a commit to haim0n/python-storage that referenced this issue Nov 22, 2020
This way '_PropertyMixin.patch' will send them to server.
Fixes googleapis#322
haim0n added a commit to haim0n/python-storage that referenced this issue Nov 22, 2020
This way '_PropertyMixin.patch' will send them to server.
Fixes googleapis#322
@tseaver tseaver self-assigned this Nov 24, 2020
haim0n added a commit to haim0n/python-storage that referenced this issue Nov 24, 2020
This way '_PropertyMixin.patch' will send them to server.
Fixes googleapis#322
@tseaver tseaver changed the title custom_time setter doesnt update _changes field 'Blob.custom_time' setter doesnt update '_changes' Nov 24, 2020
@tseaver tseaver closed this in #323 Nov 24, 2020
shaffeeullah added a commit to shaffeeullah/python-storage that referenced this issue Jan 26, 2021
shaffeeullah added a commit to shaffeeullah/python-storage that referenced this issue Jan 26, 2021
cojenco added a commit to cojenco/python-storage that referenced this issue Oct 13, 2021
cojenco added a commit to cojenco/python-storage that referenced this issue Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants