Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle data dict type in retry.is_etag_in_json(data) #481

Closed
cojenco opened this issue Jun 25, 2021 · 0 comments · Fixed by #483
Closed

Handle data dict type in retry.is_etag_in_json(data) #481

cojenco opened this issue Jun 25, 2021 · 0 comments · Fixed by #483
Assignees
@cojenco
Labels
api: storage Issues related to the googleapis/python-storage API. priority: p2 Moderately-important priority. Fix may not be included in next release.

Comments

@cojenco
Copy link
Contributor

cojenco commented Jun 25, 2021

retry.is_etag_in_json(data) is a helper method for conditional retries. It returns a boolean whether or not an etag is contained in the JSON body.

There seem to be use cases in which a dictionary type of data is passed into retry.is_etag_in_json(data). Currently the method is unable to handle dict type data correctly: a JSONDecodeError is caught before examining if an etag is contained within.
@cojenco cojenco self-assigned this Jun 25, 2021
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/python-storage API. label Jun 25, 2021
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Jun 26, 2021
@danielduhh danielduhh added the priority: p2 Moderately-important priority. Fix may not be included in next release. label Jun 27, 2021
@yoshi-automation yoshi-automation removed the triage me I really want to be triaged. label Jun 28, 2021
@cojenco cojenco mentioned this issue Jun 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cojenco cojenco

Labels
api: storage Issues related to the googleapis/python-storage API. priority: p2 Moderately-important priority. Fix may not be included in next release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: revise and rename is_etag_in_json(data) googleapis/python-storage
3 participants
@danielduhh @yoshi-automation @cojenco