Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage): remove expiration strict conversion #106

Merged
merged 2 commits into from Apr 16, 2020

Conversation

@HemangChothani
Copy link
Contributor

@HemangChothani HemangChothani commented Apr 14, 2020

Fixes #105

@HemangChothani
Copy link
Contributor Author

@HemangChothani HemangChothani commented Apr 14, 2020

Doc is failing because of 100 issue, so first need to merge 103 PR.

Copy link
Member

@frankyn frankyn left a comment

Thanks @HemangChothani LGTM!

(Thanks @andrewsg for picking up the review)

@gcf-merge-on-green
Copy link

@gcf-merge-on-green gcf-merge-on-green bot commented Apr 16, 2020

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

1 similar comment
@gcf-merge-on-green
Copy link

@gcf-merge-on-green gcf-merge-on-green bot commented Apr 16, 2020

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

@gcf-merge-on-green gcf-merge-on-green bot merged commit 9550dad into googleapis:master Apr 16, 2020
3 checks passed
cojenco added a commit to cojenco/python-storage that referenced this issue Oct 13, 2021
cojenco added a commit to cojenco/python-storage that referenced this issue Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants