Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add *generation*match args into Blob.compose() #122

Merged
merged 14 commits into from Jun 9, 2020

Conversation

@IlyaFaer
Copy link
Member

@IlyaFaer IlyaFaer commented Apr 30, 2020

Add ifGenerationMatch and ifMetagenerationMatch arguments into Blob.compose() method.
Towards #127

@IlyaFaer IlyaFaer requested a review from frankyn Apr 30, 2020
@IlyaFaer IlyaFaer marked this pull request as ready for review Apr 30, 2020
google/cloud/storage/blob.py Show resolved Hide resolved
tests/system/test_system.py Show resolved Hide resolved
google/cloud/storage/blob.py Show resolved Hide resolved
google/cloud/storage/blob.py Show resolved Hide resolved
Copy link
Member

@frankyn frankyn left a comment

LGTM pending @andrewsg approval.

Copy link
Contributor

@andrewsg andrewsg left a comment

Thanks!

@frankyn frankyn merged commit dc01c59 into googleapis:master Jun 9, 2020
3 checks passed
@IlyaFaer IlyaFaer deleted the compose_generation_match branch Jun 10, 2020
cojenco added a commit to cojenco/python-storage that referenced this issue Oct 13, 2021
* feat: add *generation*match args into Blob.compose()

* add test case with error

* new compose surface

* Revert "new compose surface"

This reverts commit 2ddda40.

* add an error for different length args, add a usage example

* add condition to avoid sending params with None

* specify comments

Co-authored-by: Frank Natividad <frankyn@users.noreply.github.com>
cojenco added a commit to cojenco/python-storage that referenced this issue Oct 13, 2021
* feat: add *generation*match args into Blob.compose()

* add test case with error

* new compose surface

* Revert "new compose surface"

This reverts commit 2ddda40.

* add an error for different length args, add a usage example

* add condition to avoid sending params with None

* specify comments

Co-authored-by: Frank Natividad <frankyn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants