Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add offset and includeTrailingPrefix options to list_blobs #125

Merged
merged 4 commits into from May 5, 2020

Conversation

@andrewsg
Copy link
Contributor

@andrewsg andrewsg commented May 1, 2020

No description provided.

@andrewsg andrewsg requested review from crwilcox and frankyn May 1, 2020
Copy link
Member

@frankyn frankyn left a comment

Thanks @andrewsg, added two nits

tests/system/test_system.py Outdated Show resolved Hide resolved
blobs = list(page)
self.assertEqual([blob.name for blob in blobs], ["file01.txt", "parent/"])
self.assertIsNone(iterator.next_page_token)
self.assertEqual(iterator.prefixes, set(["parent/"]))
Copy link
Member

@frankyn frankyn May 4, 2020

how is this request different when include_trailinig_delimitier=False? I don't see the difference between the system test in this case.

Copy link
Contributor Author

@andrewsg andrewsg May 4, 2020

The difference is that this is the only name that includes parent/ in self.assertEqual([blob.name for blob in blobs], ["file01.txt", "parent/"]).

Copy link
Contributor Author

@andrewsg andrewsg May 4, 2020

I'll leave this for you to resolve if you're satisfied with that explanation

frankyn
frankyn approved these changes May 5, 2020
Copy link
Member

@frankyn frankyn left a comment

LGTM, thank you!

@frankyn frankyn merged commit d84c0dd into master May 5, 2020
3 checks passed
@tseaver tseaver deleted the new-list-flags branch Aug 24, 2021
cojenco added a commit to cojenco/python-storage that referenced this issue Oct 13, 2021
…gleapis#125)

* feat: add offset and includeTrailingPrefix options to list_blobs

* lint

* fix comment typo in system tests

Co-authored-by: Frank Natividad <frankyn@users.noreply.github.com>
cojenco added a commit to cojenco/python-storage that referenced this issue Oct 13, 2021
…gleapis#125)

* feat: add offset and includeTrailingPrefix options to list_blobs

* lint

* fix comment typo in system tests

Co-authored-by: Frank Natividad <frankyn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants