Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add helper for bucket bound hostname URLs #137

Merged

Conversation

@IlyaFaer
Copy link
Member

@IlyaFaer IlyaFaer commented May 7, 2020

Closes #121

google/cloud/storage/_helpers.py Outdated Show resolved Hide resolved
@IlyaFaer IlyaFaer requested review from frankyn, andrewsg and crwilcox May 7, 2020
@IlyaFaer IlyaFaer marked this pull request as ready for review May 7, 2020
Copy link
Member

@frankyn frankyn left a comment

Thanks for sending this change @IlyaFaer, left a question.

google/cloud/storage/_helpers.py Outdated Show resolved Hide resolved
google/cloud/storage/_helpers.py Outdated Show resolved Hide resolved
@gcf-merge-on-green
Copy link
Contributor

@gcf-merge-on-green gcf-merge-on-green bot commented May 27, 2020

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

@gcf-merge-on-green
Copy link
Contributor

@gcf-merge-on-green gcf-merge-on-green bot commented May 27, 2020

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

@gcf-merge-on-green
Copy link
Contributor

@gcf-merge-on-green gcf-merge-on-green bot commented May 28, 2020

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot merged commit b26f9fa into googleapis:master May 28, 2020
3 checks passed
@IlyaFaer IlyaFaer deleted the bucker_bound_hostname_helper branch May 28, 2020
cojenco added a commit to cojenco/python-storage that referenced this issue Oct 13, 2021
cojenco added a commit to cojenco/python-storage that referenced this issue Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants