Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage): add projection parameter to blob.reload method #146

Merged
merged 4 commits into from May 15, 2020

Conversation

@HemangChothani
Copy link
Contributor

@HemangChothani HemangChothani commented May 14, 2020

Fixes #136

Copy link
Member

@frankyn frankyn left a comment

Please add a system test. Otherwise LGTM

Copy link
Member

@frankyn frankyn left a comment

Thank you, have one last nit.

@@ -135,6 +135,7 @@ def _query_params(self):

def reload(
self,
projection="noAcl",
Copy link
Member

@frankyn frankyn May 15, 2020

Can you move this parameter after the client parameter?

@frankyn frankyn merged commit ddad20b into googleapis:master May 15, 2020
3 checks passed
IlyaFaer added a commit to q-logic/python-storage that referenced this issue May 20, 2020
…pis#146)

* fix(storage): add projection parameter to blob.reload method

* fix(storage): add system test

* fix(storage): nit
cojenco added a commit to cojenco/python-storage that referenced this issue Oct 13, 2021
…pis#146)

* fix(storage): add projection parameter to blob.reload method

* fix(storage): add system test

* fix(storage): nit
cojenco added a commit to cojenco/python-storage that referenced this issue Oct 13, 2021
…pis#146)

* fix(storage): add projection parameter to blob.reload method

* fix(storage): add system test

* fix(storage): nit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants