Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add timeouts to Blob methods where missing #185

Merged
merged 4 commits into from Jul 21, 2020
Merged

Conversation

@plamut
Copy link
Contributor

@plamut plamut commented Jun 18, 2020

Closes #183.

This PR adds customizable timeouts to various Blob methods that previously didn't have that, because the underlying dependency google-resumable-media-python lacked support for it.

There is a resumable media PR that will add that support, and this PR depends on it. We need to wait until that gets merged and released.

PR checklist

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
Copy link
Contributor

@HemangChothani HemangChothani left a comment

LGTM! I think need a googleapis/google-resumable-media-python#116 PR to merge first and release google-resumable-media.

@plamut
Copy link
Contributor Author

@plamut plamut commented Jun 19, 2020

@HemangChothani Indeed, that's the PR linked in the PR description. We need to wait for it to be released before this one can be merged.

@plamut
Copy link
Contributor Author

@plamut plamut commented Jun 29, 2020

The related resumable media PR has been merged, now just awaiting a new release to unblock this one.

@tseaver
Copy link
Contributor

@tseaver tseaver commented Jul 16, 2020

@plamut I have just approved the release PR for google-resumable-media-python.

@plamut plamut requested a review from HemangChothani Jul 17, 2020
@plamut plamut merged commit 6eeb855 into googleapis:master Jul 21, 2020
3 checks passed
@plamut plamut deleted the iss-183 branch Jul 21, 2020
cojenco added a commit to cojenco/python-storage that referenced this issue Oct 13, 2021
* feat: add timeouts to Blob methods where missing

* Require google-resumable-media version 0.6.0+
cojenco added a commit to cojenco/python-storage that referenced this issue Oct 13, 2021
* feat: add timeouts to Blob methods where missing

* Require google-resumable-media version 0.6.0+
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants