Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(blob): base64 includes additional characters #258

Merged
merged 2 commits into from Sep 2, 2020

Conversation

@william-silversmith
Copy link
Contributor

@william-silversmith william-silversmith commented Aug 27, 2020

Hashes were not being parsed correctly. I forgot that base64 includes the "+" and "/" characters.

https://en.wikipedia.org/wiki/Base64

image

@google-cla google-cla bot added the cla: yes label Aug 27, 2020
@william-silversmith william-silversmith changed the title fix: base64 includes '+' and '/' characters. fix: base64 includes "+" and "/" characters. Aug 27, 2020
@william-silversmith william-silversmith changed the title fix: base64 includes "+" and "/" characters. fix: base64 includes "+" and "/" characters Aug 27, 2020
@william-silversmith william-silversmith changed the title fix: base64 includes "+" and "/" characters fix(blob): base64 includes "+" and "/" characters Aug 28, 2020
@william-silversmith william-silversmith changed the title fix(blob): base64 includes "+" and "/" characters fix(blob): base64 includes additional characters Aug 28, 2020
@HemangChothani HemangChothani requested review from tseaver and frankyn and removed request for tseaver Aug 31, 2020
william-silversmith added a commit to seung-lab/cloud-files that referenced this issue Sep 2, 2020
Waiting on googleapis/python-storage#258
Until that patch is released, GCS will error on perfectly good
files randomly if + or / characters are included in the base64
representation of the hash.
tseaver
tseaver approved these changes Sep 2, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit cf0774a into googleapis:master Sep 2, 2020
4 checks passed
@william-silversmith
Copy link
Contributor Author

@william-silversmith william-silversmith commented Sep 2, 2020

Thank you again Tres! Sorry for the boo boo.

MartinKilonzo added a commit to MartinKilonzo/python-storage that referenced this issue Sep 15, 2020
Hashes were not being parsed correctly. I forgot that base64 includes the "+" and "/" characters. 

https://en.wikipedia.org/wiki/Base64

<img width="656" alt="image" src="https://user-images.githubusercontent.com/2517065/91491542-3329ee80-e882-11ea-9665-4eaa564b406b.png">
cojenco added a commit to cojenco/python-storage that referenced this issue Oct 13, 2021
Hashes were not being parsed correctly. I forgot that base64 includes the "+" and "/" characters. 

https://en.wikipedia.org/wiki/Base64

<img width="656" alt="image" src="https://user-images.githubusercontent.com/2517065/91491542-3329ee80-e882-11ea-9665-4eaa564b406b.png">
cojenco added a commit to cojenco/python-storage that referenced this issue Oct 13, 2021
Hashes were not being parsed correctly. I forgot that base64 includes the "+" and "/" characters. 

https://en.wikipedia.org/wiki/Base64

<img width="656" alt="image" src="https://user-images.githubusercontent.com/2517065/91491542-3329ee80-e882-11ea-9665-4eaa564b406b.png">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants