Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: preserve existing blob hashes when 'X-Goog-Hash header' is not present #267

Merged
merged 5 commits into from Sep 16, 2020

Conversation

@MartinKilonzo
Copy link
Contributor

@MartinKilonzo MartinKilonzo commented Sep 2, 2020

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #266 馃

@google-cla google-cla bot added the cla: yes label Sep 2, 2020
@MartinKilonzo MartinKilonzo changed the title Returns blob hashes (md5, crc32c) when 'X-Goog-Hash header' is not present fix(blob.py): Returns blob hashes (md5, crc32c) when 'X-Goog-Hash header' is not present Sep 2, 2020
google/cloud/storage/blob.py Outdated Show resolved Hide resolved
tests/unit/test_blob.py Show resolved Hide resolved
@google-cla
Copy link

@google-cla google-cla bot commented Sep 15, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

鈩癸笍 Googlers: Go here for more info.

@google-cla google-cla bot added cla: no and removed cla: yes labels Sep 15, 2020
@google-cla
Copy link

@google-cla google-cla bot commented Sep 15, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

鈩癸笍 Googlers: Go here for more info.

1 similar comment
@google-cla
Copy link

@google-cla google-cla bot commented Sep 15, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

鈩癸笍 Googlers: Go here for more info.

@google-cla
Copy link

@google-cla google-cla bot commented Sep 15, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

鈩癸笍 Googlers: Go here for more info.

@google-cla
Copy link

@google-cla google-cla bot commented Sep 15, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

鈩癸笍 Googlers: Go here for more info.

@google-cla
Copy link

@google-cla google-cla bot commented Sep 15, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

鈩癸笍 Googlers: Go here for more info.

@google-cla
Copy link

@google-cla google-cla bot commented Sep 15, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

鈩癸笍 Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

@googlebot googlebot commented Sep 15, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

鈩癸笍 Googlers: Go here for more info.

@MartinKilonzo
Copy link
Contributor Author

@MartinKilonzo MartinKilonzo commented Sep 15, 2020

Thanks for the review!
Added the proposed changes. @tseaver, would you mind checking your CLA per @googlebot:

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

鈩癸笍 Googlers: Go here for more info.

@tseaver
Copy link
Contributor

@tseaver tseaver commented Sep 16, 2020

@googlebot I fixed it

@google-cla
Copy link

@google-cla google-cla bot commented Sep 16, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

鈩癸笍 Googlers: Go here for more info.

@tseaver
Copy link
Contributor

@tseaver tseaver commented Sep 16, 2020

@googlebot I consent

@google-cla
Copy link

@google-cla google-cla bot commented Sep 16, 2020

CLAs look good, thanks!

鈩癸笍 Googlers: Go here for more info.

@google-cla
Copy link

@google-cla google-cla bot commented Sep 16, 2020

鈽癸笍 Sorry, but only Googlers may change the label cla: yes.

@tseaver tseaver changed the title fix(blob.py): Returns blob hashes (md5, crc32c) when 'X-Goog-Hash header' is not present fix: preserve existing blob hashes when 'X-Goog-Hash header' is not present Sep 16, 2020
@tseaver tseaver merged commit 277afb8 into googleapis:master Sep 16, 2020
4 checks passed
@tseaver
Copy link
Contributor

@tseaver tseaver commented Sep 16, 2020

@MartinKilonzo Thanks for persevering!

cojenco added a commit to cojenco/python-storage that referenced this issue Oct 13, 2021
鈥esent (googleapis#267)

Co-authored-by: Tres Seaver <tseaver@palladion.com>
cojenco added a commit to cojenco/python-storage that referenced this issue Oct 13, 2021
鈥esent (googleapis#267)

Co-authored-by: Tres Seaver <tseaver@palladion.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants