Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add requests as a dependency #271

Merged
merged 2 commits into from Sep 16, 2020
Merged

Conversation

@HemangChothani
Copy link
Contributor

@HemangChothani HemangChothani commented Sep 15, 2020

Fixes #268

Copy link
Contributor

@andrewsg andrewsg left a comment

Thank you for taking the time to submit this.

@andrewsg
Copy link
Contributor

@andrewsg andrewsg commented Sep 15, 2020

Build error looks unrelated at first glance, but we need to investigate before merging

@HemangChothani
Copy link
Contributor Author

@HemangChothani HemangChothani commented Sep 16, 2020

System test issue will be fixed by PR #273

@plamut
Copy link
Contributor

@plamut plamut commented Sep 16, 2020

Restricting the PubSub version to <2.0.0 indeed helped, system tests now pass again.

@plamut plamut merged commit ec52b38 into googleapis:master Sep 16, 2020
4 checks passed
cojenco added a commit to cojenco/python-storage that referenced this issue Oct 13, 2021
Co-authored-by: Peter Lamut <plamut@users.noreply.github.com>
cojenco added a commit to cojenco/python-storage that referenced this issue Oct 13, 2021
Co-authored-by: Peter Lamut <plamut@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants