Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add classifiers for python3.9 and remove for python3.5 #295

Merged
merged 9 commits into from Nov 13, 2020

Conversation

@HemangChothani
Copy link
Contributor

@HemangChothani HemangChothani commented Oct 15, 2020

Towards #292

  • nox.py file is generated by synthtool, so didn't include changes here.
@HemangChothani HemangChothani requested review from tseaver and crwilcox Oct 15, 2020
@google-cla google-cla bot added the cla: yes label Oct 15, 2020
@HemangChothani HemangChothani linked an issue that may be closed by this pull request Oct 15, 2020
@andrewsg
Copy link
Contributor

@andrewsg andrewsg commented Oct 15, 2020

Will this refuse to install on Python 2.7 or will it just no longer be recommended?

@tseaver
Copy link
Contributor

@tseaver tseaver commented Nov 11, 2020

@andrewsg The following will refuse to install on 2.7, at least with any recent setuptools:

    python_requires=">=3.6",

This definitely needs to get merged as a breaking change.

@crwilcox
Copy link
Contributor

@crwilcox crwilcox commented Nov 11, 2020

I'd recommend waiting to remove Python 2 until other breaking changes. At this time supporting Python 2 isn't providing any drag, but I think once it is we can remove it. @andrewsg @frankyn do we know of any changes that are also breaking to bundle?

noxfile.py Outdated Show resolved Hide resolved
setup.py Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
@tseaver tseaver changed the title feat: add classifiers for python3.9 and remove for python2.7 and 3.5 feat: add classifiers for python3.9 and remove for python3.5 Nov 13, 2020
@tseaver tseaver merged commit f072825 into googleapis:master Nov 13, 2020
4 checks passed
shaffeeullah added a commit to shaffeeullah/python-storage that referenced this issue Jan 26, 2021
…pis#295)

Co-authored-by: Frank Natividad <frankyn@users.noreply.github.com>
Co-authored-by: Tres Seaver <tseaver@palladion.com>
shaffeeullah added a commit to shaffeeullah/python-storage that referenced this issue Jan 26, 2021
…pis#295)

Co-authored-by: Frank Natividad <frankyn@users.noreply.github.com>
Co-authored-by: Tres Seaver <tseaver@palladion.com>
cojenco added a commit to cojenco/python-storage that referenced this issue Oct 13, 2021
…pis#295)

Co-authored-by: Frank Natividad <frankyn@users.noreply.github.com>
Co-authored-by: Tres Seaver <tseaver@palladion.com>
cojenco added a commit to cojenco/python-storage that referenced this issue Oct 13, 2021
…pis#295)

Co-authored-by: Frank Natividad <frankyn@users.noreply.github.com>
Co-authored-by: Tres Seaver <tseaver@palladion.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

6 participants