Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: self-upload files for Unicode system test #296

Merged
merged 1 commit into from Oct 15, 2020
Merged

Conversation

@andrewsg
Copy link
Contributor

@andrewsg andrewsg commented Oct 15, 2020

TestUnicode system tests are failing because a public repository of files was deleted. Rather than replace those public files, this PR self-uploads the files as per other tests.

While using a public bucket for this test had some advantages in test fidelity, the brittleness of relying on external static files is a significant problem and this is a compromise solution.

@andrewsg andrewsg requested a review from frankyn Oct 15, 2020
@google-cla google-cla bot added the cla: yes label Oct 15, 2020
@andrewsg andrewsg force-pushed the fix-unicode-system-test branch from a1d1954 to dd6f749 Oct 15, 2020
@andrewsg andrewsg merged commit 6f865d9 into master Oct 15, 2020
4 checks passed
@andrewsg andrewsg deleted the fix-unicode-system-test branch Oct 16, 2020
cojenco added a commit to cojenco/python-storage that referenced this issue Oct 13, 2021
cojenco added a commit to cojenco/python-storage that referenced this issue Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants