Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add change in 'Blob.custom_time' to changes #323

Merged
merged 1 commit into from Nov 24, 2020

Conversation

@haim0n
Copy link
Contributor

@haim0n haim0n commented Nov 22, 2020

This way '_PropertyMixin.patch' will send them to server.

Fixes #322 馃

@google-cla
Copy link

@google-cla google-cla bot commented Nov 22, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

馃摑 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

鈩癸笍 Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Nov 22, 2020
@google-cla google-cla bot added cla: yes and removed cla: no labels Nov 22, 2020
tseaver added a commit that referenced this issue Nov 24, 2020
Also, add test assertions for 'metadata' setter for the same issue.

Closes #323
Copy link
Contributor

@tseaver tseaver left a comment

Thanks for the patch. Please add unit test assertions (as I did in PR #325, which I am closing in favor of this one).

This way '_PropertyMixin.patch' will send them to server.
Fixes googleapis#322
@haim0n
Copy link
Contributor Author

@haim0n haim0n commented Nov 24, 2020

Thanks for the patch. Please add unit test assertions (as I did in PR #325, which I am closing in favor of this one).

done

@tseaver tseaver removed the automerge label Nov 24, 2020
@tseaver tseaver changed the title fix: Add change in 'Blob.custom_time' to changes fix: add change in 'Blob.custom_time' to changes Nov 24, 2020
@tseaver tseaver merged commit 5174154 into googleapis:master Nov 24, 2020
5 checks passed
shaffeeullah added a commit to shaffeeullah/python-storage that referenced this issue Jan 26, 2021
shaffeeullah added a commit to shaffeeullah/python-storage that referenced this issue Jan 26, 2021
cojenco added a commit to cojenco/python-storage that referenced this issue Oct 13, 2021
cojenco added a commit to cojenco/python-storage that referenced this issue Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants