Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: address incorrect usage of request preconditions #366

Merged
merged 1 commit into from Jan 28, 2021
Merged

fix: address incorrect usage of request preconditions #366

merged 1 commit into from Jan 28, 2021

Conversation

@frankyn
Copy link
Member

@frankyn frankyn commented Jan 26, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #364 馃

@google-cla google-cla bot added the cla: yes label Jan 26, 2021
@frankyn frankyn requested a review from andrewsg Jan 27, 2021
@frankyn frankyn marked this pull request as ready for review Jan 27, 2021
@frankyn frankyn requested a review from Jan 27, 2021
@frankyn frankyn merged commit 321658c into master Jan 28, 2021
5 checks passed
@frankyn frankyn deleted the fix-364 branch Jan 28, 2021
cojenco added a commit to cojenco/python-storage that referenced this issue Oct 13, 2021
cojenco added a commit to cojenco/python-storage that referenced this issue Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants