Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set custom_time on uploads #374

Merged
merged 1 commit into from Feb 8, 2021
Merged

Conversation

@tritone
Copy link
Contributor

@tritone tritone commented Feb 8, 2021

The custom_time property was incorrectly not included as a field
that could be set on object upload.

Fixes #372

The custom_time property was incorrectly not included as a field
that could be set on object upload.

Fixes googleapis#372
@tritone tritone requested a review from Feb 8, 2021
@google-cla google-cla bot added the cla: yes label Feb 8, 2021
Copy link
Contributor

@andrewsg andrewsg left a comment

Thanks Chris!

@tritone tritone merged commit f048be1 into googleapis:master Feb 8, 2021
5 checks passed
@tritone tritone deleted the customtime-upload branch Feb 8, 2021
cojenco added a commit to cojenco/python-storage that referenced this issue Oct 13, 2021
The custom_time property was incorrectly not included as a field
that could be set on object upload.

Fixes googleapis#372
cojenco added a commit to cojenco/python-storage that referenced this issue Oct 13, 2021
The custom_time property was incorrectly not included as a field
that could be set on object upload.

Fixes googleapis#372
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants