Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow metadata keys to be cleared #383

Merged
merged 1 commit into from Feb 17, 2021
Merged

Conversation

@tritone
Copy link
Contributor

@tritone tritone commented Feb 17, 2021

Metadata keys can be cleared in the JSON API by setting the value
to null; however this doesn't currently work through this library.
This PR allows users to clear metadata keys by setting the value
to None and documents how users should do this.

Fixes #381

Metadata keys can be cleared in the JSON API by setting the value
to null; however this doesn't currently work through this library.
This PR allows users to clear metadata keys by setting the value
to None and documents how users should do this.

Fixes googleapis#381
@tritone tritone requested a review from Feb 17, 2021
@tritone tritone requested a review from as a code owner Feb 17, 2021
@google-cla google-cla bot added the cla: yes label Feb 17, 2021
@tritone tritone merged commit 79d27da into googleapis:master Feb 17, 2021
5 checks passed
@tritone tritone deleted the metadata-fix branch Feb 17, 2021
cojenco added a commit to cojenco/python-storage that referenced this issue Oct 13, 2021
Metadata keys can be cleared in the JSON API by setting the value
to null; however this doesn't currently work through this library.
This PR allows users to clear metadata keys by setting the value
to None and documents how users should do this.

Fixes googleapis#381
cojenco added a commit to cojenco/python-storage that referenced this issue Oct 13, 2021
Metadata keys can be cleared in the JSON API by setting the value
to null; however this doesn't currently work through this library.
This PR allows users to clear metadata keys by setting the value
to None and documents how users should do this.

Fixes googleapis#381
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants