Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update batch connection to request api endpoint info from client #392

Merged
merged 2 commits into from Mar 9, 2021

Conversation

@cojenco
Copy link
Contributor

@cojenco cojenco commented Mar 9, 2021

Instantiating a batch creates a new connection. Since api endpoint and client info were not requested from the client, the batch did not respect client api endpoint (STORAGE_EMULATOR_HOST). This PR updates the batch constructor to request api endpoint and client info from client.

Fixes #376

@cojenco cojenco requested a review from Mar 9, 2021
@cojenco cojenco requested a review from as a code owner Mar 9, 2021
@google-cla google-cla bot added the cla: yes label Mar 9, 2021
Copy link
Contributor

@andrewsg andrewsg left a comment

Looks great, thanks!

@cojenco cojenco merged commit 91fc6d9 into master Mar 9, 2021
3 checks passed
@cojenco cojenco deleted the batch-376 branch Mar 9, 2021
cojenco added a commit to cojenco/python-storage that referenced this issue Oct 13, 2021
…googleapis#392)

* bug: let Batch Connection request api endpoint info from Client

* add unit test coverage

Co-authored-by: Cathy Ouyang <cathyo@google.com>
cojenco added a commit to cojenco/python-storage that referenced this issue Oct 13, 2021
…googleapis#392)

* bug: let Batch Connection request api endpoint info from Client

* add unit test coverage

Co-authored-by: Cathy Ouyang <cathyo@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants