Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: revise docstrings for generate_signed_url #408

Merged
merged 4 commits into from Apr 19, 2021

Conversation

@DiegoQueiroz
Copy link
Contributor

@DiegoQueiroz DiegoQueiroz commented Apr 14, 2021

The assumed property is signer_email and not service_account_email.
In nowhere a property called service_account_email is read from credentials, but signer_email is.

Fixes #406 馃

The assumed property is `signer_email` and not `service_account_email`.
In nowhere a property called `service_account_email` is read from `credentials`, but `signer_email` is.
The assumed property is `signer_email` and not `service_account_email`.
In nowhere a property called `service_account_email` is read from `credentials`, but `signer_email` is.
@DiegoQueiroz DiegoQueiroz requested a review from Apr 14, 2021
@DiegoQueiroz DiegoQueiroz requested a review from as a code owner Apr 14, 2021
@google-cla google-cla bot added the cla: yes label Apr 14, 2021
@DiegoQueiroz
Copy link
Contributor Author

@DiegoQueiroz DiegoQueiroz commented Apr 14, 2021

I really suck with Git, sorry for that.

Apparently, there is something wrong with my commit messages, but you got the idea...

@cojenco cojenco changed the title Adjusting comment for accuracy docs: revise docstrings for generate_signed_url Apr 19, 2021
@cojenco cojenco merged commit f090548 into googleapis:master Apr 19, 2021
3 checks passed
cojenco added a commit to cojenco/python-storage that referenced this issue Oct 13, 2021
* Adjusting comment for accuracy

The assumed property is `signer_email` and not `service_account_email`.
In nowhere a property called `service_account_email` is read from `credentials`, but `signer_email` is.

* fix: adjusting comment for accuracy

The assumed property is `signer_email` and not `service_account_email`.
In nowhere a property called `service_account_email` is read from `credentials`, but `signer_email` is.

Co-authored-by: cojenco <59401799+cojenco@users.noreply.github.com>
cojenco added a commit to cojenco/python-storage that referenced this issue Oct 13, 2021
* Adjusting comment for accuracy

The assumed property is `signer_email` and not `service_account_email`.
In nowhere a property called `service_account_email` is read from `credentials`, but `signer_email` is.

* fix: adjusting comment for accuracy

The assumed property is `signer_email` and not `service_account_email`.
In nowhere a property called `service_account_email` is read from `credentials`, but `signer_email` is.

Co-authored-by: cojenco <59401799+cojenco@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants