Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: revise docstrings for generate_signed_url #408

Merged
merged 4 commits into from Apr 19, 2021
Merged

docs: revise docstrings for generate_signed_url #408

merged 4 commits into from Apr 19, 2021

Commits on Apr 14, 2021

  1. Adjusting comment for accuracy 

    The assumed property is `signer_email` and not `service_account_email`.
In nowhere a property called `service_account_email` is read from `credentials`, but `signer_email` is.
    @DiegoQueiroz
    DiegoQueiroz committed Apr 14, 2021
    Copy the full SHA
    30616fa View commit details
    Browse the repository at this point in the history

  2. fix: adjusting comment for accuracy 

    The assumed property is `signer_email` and not `service_account_email`.
In nowhere a property called `service_account_email` is read from `credentials`, but `signer_email` is.
    @DiegoQueiroz
    DiegoQueiroz committed Apr 14, 2021
    Copy the full SHA
    36e1240 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'patch-1' of https://github.com/DiegoQueiroz/python-storage 

     into pr/407
    @DiegoQueiroz
    DiegoQueiroz committed Apr 14, 2021
    Copy the full SHA
    132a33e View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2021

  1. Merge branch 'master' into patch-1

    @cojenco
    cojenco committed Apr 19, 2021
    Copy the full SHA
    a091972 View commit details
    Browse the repository at this point in the history