Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add getters and setters for encryption_key and kms_key_name #409

Merged
merged 5 commits into from Apr 20, 2021

Conversation

@cojenco
Copy link
Contributor

@cojenco cojenco commented Apr 14, 2021

Fixes for Blob:

  • add getters and setters for attributes encryption_key and kms_key_name
  • revise docstring descriptions and formatting

Fixes #390 馃

@tseaver tseaver changed the title fix: add getters and setters for encryption_key and kms_key_name feat: add getters and setters for encryption_key and kms_key_name Apr 20, 2021
@tseaver
Copy link
Contributor

@tseaver tseaver commented Apr 20, 2021

Note that this is a new feature, not a bugfix. I updated the PR title to reflect that.

@cojenco cojenco merged commit 2adfb59 into master Apr 20, 2021
4 checks passed
@cojenco cojenco deleted the setter-390 branch Apr 20, 2021
cojenco added a commit to cojenco/python-storage that referenced this issue Oct 13, 2021
鈥gleapis#409)

* fix: add getters and setters for attributes encryption_key and kms_key_name

* fix docstring formatting

* revise docstring

Co-authored-by: Tres Seaver <tseaver@palladion.com>
cojenco added a commit to cojenco/python-storage that referenced this issue Oct 13, 2021
鈥gleapis#409)

* fix: add getters and setters for attributes encryption_key and kms_key_name

* fix docstring formatting

* revise docstring

Co-authored-by: Tres Seaver <tseaver@palladion.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants