Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage): fix incorrect mtime by UTC offset #42

Merged

Conversation

@HemangChothani
Copy link
Contributor

@HemangChothani HemangChothani commented Feb 4, 2020

Fixes #4

@HemangChothani
Copy link
Contributor Author

@HemangChothani HemangChothani commented Mar 5, 2020

PTAL.

@frankyn
Copy link
Member

@frankyn frankyn commented Apr 17, 2020

Thanks for your patience @HemangChothani, this LGTM. IIUC, you're making last update consistent with server side after objects are downloaded to a local file.

@frankyn frankyn merged commit 76bd652 into googleapis:master Apr 17, 2020
3 checks passed
cojenco added a commit to cojenco/python-storage that referenced this issue Oct 13, 2021
Co-authored-by: Christopher Wilcox <crwilcox@google.com>
Co-authored-by: Frank Natividad <frankyn@users.noreply.github.com>
cojenco added a commit to cojenco/python-storage that referenced this issue Oct 13, 2021
Co-authored-by: Christopher Wilcox <crwilcox@google.com>
Co-authored-by: Frank Natividad <frankyn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants