Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: apply idempotency policies for ACLs #458

Merged
merged 7 commits into from Jun 8, 2021
Merged

Conversation

@tseaver
Copy link
Contributor

@tseaver tseaver commented Jun 8, 2021

Toward #38.

  • Use None as default retry for Client._patch_resource and Client._put_resource helpers (they can only be idempotent conditionally, so the caller needs to configure the retry).
  • Remove retry argument from ACL.save, ACL.save_predefined, and ACL.clear (ACLs cannot be saved idempotently).
  • Likewise remove retry argument from Bucket.make_public, Bucket.make_private, Blob.make_public, and Blob.make_private, which only perform saves on ACLs.
@tseaver tseaver requested review from andrewsg and Jun 8, 2021
@tseaver tseaver requested a review from as a code owner Jun 8, 2021
@google-cla google-cla bot added the cla: yes label Jun 8, 2021
google/cloud/storage/acl.py Show resolved Hide resolved
@tseaver tseaver mentioned this pull request Jun 8, 2021
Copy link
Contributor

@andrewsg andrewsg left a comment

Thanks!

@tseaver tseaver merged commit 2232f38 into master Jun 8, 2021
6 checks passed
@tseaver tseaver deleted the 38-apply-idempotency-policies branch Jun 8, 2021
cojenco added a commit to cojenco/python-storage that referenced this issue Oct 13, 2021
* fix: use 'retry=None' as default for 'Client._put_resource'
* fix: use 'retry=None' as default for 'Client._patch_resource'
* fix: force 'retry=None' for 'ACL.{save,save_predefined,clear}'
* fix: remove 'retry' arg from 'Bucket.make_public'
* fix: remove 'retry' arg from 'Bucket.make_private'
* fix: remove 'retry' arg from 'Blob.make_public'
* fix: remove 'retry' arg from 'Blob.make_private'

Per idempotency policy.
cojenco added a commit to cojenco/python-storage that referenced this issue Oct 13, 2021
* fix: use 'retry=None' as default for 'Client._put_resource'
* fix: use 'retry=None' as default for 'Client._patch_resource'
* fix: force 'retry=None' for 'ACL.{save,save_predefined,clear}'
* fix: remove 'retry' arg from 'Bucket.make_public'
* fix: remove 'retry' arg from 'Bucket.make_private'
* fix: remove 'retry' arg from 'Blob.make_public'
* fix: remove 'retry' arg from 'Blob.make_private'

Per idempotency policy.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants