Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add preconditions and retry configuration to blob.create_resumable_upload_session #484

Merged
merged 3 commits into from Jun 30, 2021

Conversation

@cojenco
Copy link
Contributor

@cojenco cojenco commented Jun 29, 2021

This adds preconditions and retry configuration to the upload entry method blob.create_resumable_upload_session(), in the continuation of #447 and #480.

This exposes the method to preconditions and therefore can make the operation conditional. It can also be configured with Retry objects and ConditionalRetryPolicy objects.

@cojenco cojenco requested review from andrewsg, tritone and Jun 29, 2021
@cojenco cojenco requested a review from as a code owner Jun 29, 2021
@google-cla google-cla bot added the cla: yes label Jun 29, 2021
@cojenco cojenco changed the title feat: add preconditions and retry configuration to blob.create_resumable_upload_session()()` feat: add preconditions and retry configuration to blob.create_resumable_upload_session Jun 29, 2021
Copy link
Contributor

@tritone tritone left a comment

Generally looks good. Did you test against the emulator that things are working?

def test_create_resumable_upload_session_with_conditional_retry_failure(self):
self._create_resumable_upload_session_helper(
retry=DEFAULT_RETRY_IF_GENERATION_SPECIFIED
)
Copy link
Contributor

@tritone tritone Jun 30, 2021

How does this test verify that retries don't happen?

Copy link
Contributor Author

@cojenco cojenco Jun 30, 2021

@tritone, I've tested the retry behaviors against the emulator that things are working as intended. The unit test asserts if the mock call was made with the corresponding url and query params.

Copy link
Contributor

@tritone tritone Jun 30, 2021

Sounds good!

google/cloud/storage/blob.py Show resolved Hide resolved
@cojenco cojenco mentioned this pull request Jun 30, 2021
4 tasks
@cojenco cojenco merged commit 0ae35ee into master Jun 30, 2021
6 checks passed
@cojenco cojenco deleted the add-resumable-session branch Jun 30, 2021
cojenco added a commit to cojenco/python-storage that referenced this issue Oct 13, 2021
…ble_upload_session (googleapis#484)

* feat: add preconditions and retry configuration to blob.create_resumable_upload_session

* move imports
cojenco added a commit to cojenco/python-storage that referenced this issue Oct 13, 2021
…ble_upload_session (googleapis#484)

* feat: add preconditions and retry configuration to blob.create_resumable_upload_session

* move imports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants