Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove trailing commas from error message constants #505

Merged
merged 2 commits into from Jul 15, 2021

Conversation

@rjw57
Copy link
Contributor

@rjw57 rjw57 commented Jul 15, 2021

The _DOWNLOAD_AS_STRING_DEPRECATED constant includes a dangling comma
which makes it a tuple and not a string. This causes a TypeError as reported in #501.

Fixes #501

@rjw57 rjw57 requested a review from Jul 15, 2021
@rjw57 rjw57 requested a review from as a code owner Jul 15, 2021
@google-cla google-cla bot added the cla: yes label Jul 15, 2021
@parthea parthea changed the title blob.py: remove dangling comma in _DOWNLOAD_AS_STRING_DEPRECATED fix: TypeError in blob.download_as_string() Jul 15, 2021
@parthea parthea changed the title fix: TypeError in blob.download_as_string() fix: TypeError in blob.download_as_string Jul 15, 2021
@parthea parthea requested a review from tseaver Jul 15, 2021
@parthea parthea changed the title fix: TypeError in blob.download_as_string fix(Python 2.7): TypeError in blob.download_as_string Jul 15, 2021
@parthea parthea changed the title fix(Python 2.7): TypeError in blob.download_as_string fix: TypeError in blob.download_as_string Jul 15, 2021
Copy link
Contributor

@tseaver tseaver left a comment

Thanks very much for the patch! Can you please also remove the trailing commas for _COMPOSE_IF_GENERATION_LIST_DEPRECATED and _COMPOSE_IF_GENERATION_LIST_AND_IF_SOURCE_GENERATION_ERROR?

@tseaver tseaver changed the title fix: TypeError in blob.download_as_string fix: remove trailing commas from error message constants Jul 15, 2021
The _DOWNLOAD_AS_STRING_DEPRECATED,
_COMPOSE_IF_GENERATION_LIST_DEPRECATED and
_COMPOSE_IF_GENERATION_LIST_AND_IF_SOURCE_GENERATION_ERROR constants
include a dangling comma which make them tuples and not strings. This
causes a TypeError as reported in googleapis#501.

Closes googleapis#501
@rjw57
Copy link
Contributor Author

@rjw57 rjw57 commented Jul 15, 2021

Thanks very much for the patch! Can you please also remove the trailing commas for _COMPOSE_IF_GENERATION_LIST_DEPRECATED and _COMPOSE_IF_GENERATION_LIST_AND_IF_SOURCE_GENERATION_ERROR?

Done. I should've looked myself for any other offenders(!)

@gcf-merge-on-green gcf-merge-on-green bot merged commit d4a86ce into googleapis:master Jul 15, 2021
5 checks passed
@rjw57 rjw57 deleted the patch-1 branch Jul 15, 2021
cojenco added a commit to cojenco/python-storage that referenced this issue Oct 13, 2021
)

The _DOWNLOAD_AS_STRING_DEPRECATED constant includes a dangling comma
which makes it a tuple and not a string. This causes a TypeError as reported in googleapis#501.

Fixes googleapis#501
cojenco added a commit to cojenco/python-storage that referenced this issue Oct 13, 2021
)

The _DOWNLOAD_AS_STRING_DEPRECATED constant includes a dangling comma
which makes it a tuple and not a string. This causes a TypeError as reported in googleapis#501.

Fixes googleapis#501
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants