Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add page_size to list_blobs, list_buckets #520

Merged

Conversation

@ryanyuan
Copy link
Contributor

@ryanyuan ryanyuan commented Jul 22, 2021

Adding page_size to list_blobs() and list_buckets() to have better support page_iterator.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #425 馃

@tseaver tseaver merged commit c5f4ad8 into googleapis:master Jul 22, 2021
7 checks passed
@tseaver
Copy link
Contributor

@tseaver tseaver commented Jul 22, 2021

@ryanyuan Thanks very much for the patch!

tseaver added a commit that referenced this issue Aug 2, 2021
Transitive dependency resolution breaks unit tests under Python 3.6
following PR #520.

Pin minima for those ranges explicitly when testing under Python 3.6.

Closes #529.
gcf-merge-on-green bot pushed a commit that referenced this issue Aug 5, 2021
#530)

Transitive dependency resolution breaks unit tests under Python 3.6
following PR #520.

Pin minima for those ranges explicitly when testing under Python 3.6.

Closes #529.
cojenco added a commit to cojenco/python-storage that referenced this issue Oct 13, 2021
googleapis#530)

Transitive dependency resolution breaks unit tests under Python 3.6
following PR googleapis#520.

Pin minima for those ranges explicitly when testing under Python 3.6.

Closes googleapis#529.
cojenco added a commit to cojenco/python-storage that referenced this issue Oct 13, 2021
googleapis#530)

Transitive dependency resolution breaks unit tests under Python 3.6
following PR googleapis#520.

Pin minima for those ranges explicitly when testing under Python 3.6.

Closes googleapis#529.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants