Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make 'requests.exceptions.ChunkedEncodingError retryable by default #526

Merged
merged 1 commit into from Jul 27, 2021

Conversation

@tseaver
Copy link
Contributor

@tseaver tseaver commented Jul 23, 2021

Closes #525.

@tseaver tseaver requested review from tswast and Jul 23, 2021
@tseaver tseaver requested a review from as a code owner Jul 23, 2021
@google-cla google-cla bot added the cla: yes label Jul 23, 2021
@andrewsg
Copy link
Contributor

@andrewsg andrewsg commented Jul 26, 2021

I think this is googleapis/google-resumable-media-python#240 which can't be solved here in the client library - PR is in the works by @cojenco

@tseaver
Copy link
Contributor Author

@tseaver tseaver commented Jul 27, 2021

@andrewsg I don't know whether the JSON API (versus the download API) can cause requests to perceive a ChunkedEncodingError -- I do know that the BigQuery API can emit them from JSON API calls (e.g, Client.list_rows(), see googleapis/python-bigquery#801).

Copy link
Contributor

@andrewsg andrewsg left a comment

Thanks for pointing that out. Sounds like we may need it here too, then.

@tseaver tseaver merged commit 4abb403 into master Jul 27, 2021
8 checks passed
@tseaver tseaver deleted the 525-retry-requests-chunked-encoding-error branch Jul 27, 2021
cojenco added a commit to cojenco/python-storage that referenced this issue Oct 13, 2021
cojenco added a commit to cojenco/python-storage that referenced this issue Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants