Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: pass explicit 'client' in '{Blob.Bucket}.from_string' examples #545

Merged
merged 3 commits into from Aug 20, 2021

Conversation

@tseaver
Copy link
Contributor

@tseaver tseaver commented Aug 19, 2021

See #540.

@tseaver tseaver requested review from cojenco and Aug 19, 2021
@tseaver tseaver requested a review from as a code owner Aug 19, 2021
@google-cla google-cla bot added the cla: yes label Aug 19, 2021
@tseaver tseaver requested a review from cojenco Aug 19, 2021
Copy link
Contributor

@cojenco cojenco left a comment

Thanks so much for the clarification!

@gcf-merge-on-green
Copy link

@gcf-merge-on-green gcf-merge-on-green bot commented Aug 20, 2021

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@tseaver
Copy link
Contributor Author

@tseaver tseaver commented Aug 20, 2021

Flaky systest is #541.

@gcf-merge-on-green gcf-merge-on-green bot merged commit 6eff22d into master Aug 20, 2021
12 checks passed
@gcf-merge-on-green gcf-merge-on-green bot deleted the 540-docs-blob-bucket-from_string-w-client branch Aug 20, 2021
cojenco added a commit to cojenco/python-storage that referenced this issue Oct 13, 2021
cojenco added a commit to cojenco/python-storage that referenced this issue Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants