Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: generate signed URLs for blobs/buckets using virtual hostname #58

Merged
merged 4 commits into from Feb 13, 2020

Conversation

@tseaver
Copy link
Contributor

@tseaver tseaver commented Feb 13, 2020

Closes #10.

Copy link
Member

@frankyn frankyn left a comment

One nit.

@@ -361,6 +361,7 @@ def generate_signed_url(
version=None,
service_account_email=None,
access_token=None,
use_virtual_hostname=False,
Copy link
Member

@frankyn frankyn Feb 13, 2020

Please use virtual_hosted_style instead.

google/cloud/storage/blob.py Outdated Show resolved Hide resolved
@tseaver tseaver force-pushed the 10-v4-signing-virtual-hostname branch from 5e949f2 to 3be7f6e Feb 13, 2020
Copy link
Member

@frankyn frankyn left a comment

LGTM

@tseaver tseaver merged commit 23df542 into master Feb 13, 2020
3 checks passed
@tseaver tseaver deleted the 10-v4-signing-virtual-hostname branch Feb 13, 2020
cojenco added a commit to cojenco/python-storage that referenced this issue Oct 13, 2021
…oogleapis#58)

* Add 'virtual_hosted_style' arg to 'Blob.generate_signed_url'
* Add 'virtual_hosted_style arg to 'Bucket.generate_signed_url'
cojenco added a commit to cojenco/python-storage that referenced this issue Oct 13, 2021
…oogleapis#58)

* Add 'virtual_hosted_style' arg to 'Blob.generate_signed_url'
* Add 'virtual_hosted_style arg to 'Bucket.generate_signed_url'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants