Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): add get notification method #77

Merged
merged 5 commits into from Mar 6, 2020

Conversation

@HemangChothani
Copy link
Contributor

@HemangChothani HemangChothani commented Mar 5, 2020

Fixes #68

Copy link
Member

@frankyn frankyn left a comment

Overall, LGTM. I have an ask for an example.

for the server response.
Can also be passed as a tuple (connect_timeout, read_timeout).
See :meth:`requests.Session.request` documentation for details.
Copy link
Member

@frankyn frankyn Mar 5, 2020

Can you add an example of how to use this helper method?

Copy link
Contributor Author

@HemangChothani HemangChothani Mar 5, 2020

Yes.

frankyn
frankyn approved these changes Mar 5, 2020
Copy link
Member

@frankyn frankyn left a comment

Thank you, LGTM.

@frankyn frankyn merged commit f602252 into googleapis:master Mar 6, 2020
3 checks passed
cojenco added a commit to cojenco/python-storage that referenced this issue Oct 13, 2021
* feat(storage): add get notification method

* feat(storage): address comments

* feat(storage): add an example

* feat(storage): remove an extra blank

Co-authored-by: Frank Natividad <frankyn@users.noreply.github.com>
cojenco added a commit to cojenco/python-storage that referenced this issue Oct 13, 2021
* feat(storage): add get notification method

* feat(storage): address comments

* feat(storage): add an example

* feat(storage): remove an extra blank

Co-authored-by: Frank Natividad <frankyn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants