Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): add conformance tests for virtual hosted style signed URLs #83

Merged
merged 4 commits into from Mar 12, 2020

Conversation

@HemangChothani
Copy link
Contributor

@HemangChothani HemangChothani commented Mar 11, 2020

Fixes #10

Copy link
Member

@frankyn frankyn left a comment

Thanks @HemangChothani, overall LGTM. One nit on conformance tests.

"urlStyle": "VIRTUAL_HOSTED_STYLE"
},

{
Copy link
Member

@frankyn frankyn Mar 11, 2020

Please keep consistency with https://github.com/googleapis/conformance-tests/blob/master/storage/v1/v4_signatures.json#L232-L244

I don't want to create inconsistencies between main conformance tests and language specific replicas.

{
"description": "Virtual Hosted Style",
"bucket": "test-bucket",
"object": "",
Copy link
Member

@frankyn frankyn Mar 12, 2020

Remove this test with empty object. It does not match any in the existing conformance tests.

@frankyn frankyn changed the title feat(storage): add conformance tests feat(storage): add conformance tests for virtual hosted style signed URLs Mar 12, 2020
@frankyn frankyn merged commit 5adc8b0 into googleapis:master Mar 12, 2020
3 checks passed
cojenco added a commit to cojenco/python-storage that referenced this issue Oct 13, 2021
…URLs (googleapis#83)

* feat(storage): add conformance tests

* feat(storage): cover fix

* feat(storage): nit

* feat(storage): remove unnecessary test
cojenco added a commit to cojenco/python-storage that referenced this issue Oct 13, 2021
…URLs (googleapis#83)

* feat(storage): add conformance tests

* feat(storage): cover fix

* feat(storage): nit

* feat(storage): remove unnecessary test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants