Skip to content
This repository was archived by the owner on Feb 1, 2024. It is now read-only.

Conversation

@busunkim96
Copy link
Contributor

Allow google-api-core<3.0.0dev on previous release of library. Note that this PR is to a new protected branch v1, not main.

This will be followed by a release PR and is a step towards removing googleapis/google-cloud-python#10566

@busunkim96 busunkim96 requested a review from parthea March 11, 2022 02:00
@product-auto-label product-auto-label bot added the api: cloudtasks Issues related to the googleapis/python-tasks API. label Mar 11, 2022
@parthea parthea changed the title chore(deps): allow google-api-core v2 on v1 release fix(deps): require google-api-core >= 1.31.5, >= 2.3.2 on v1 release Mar 14, 2022
Copy link
Contributor

@engelke engelke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@engelke engelke merged commit 507b44c into v1 Mar 24, 2022
@engelke engelke deleted the v1-api-core-pin branch March 24, 2022 18:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: cloudtasks Issues related to the googleapis/python-tasks API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants