Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Set audience field in authenticated HTTP task example #138

Merged
merged 5 commits into from Jul 21, 2021

Conversation

ehsan-karamad
Copy link
Contributor

@ehsan-karamad ehsan-karamad commented Jul 20, 2021

feat: Setaudiencefield in authenticated HTTP task example

Unset audience will be take the URL as default value. When there are query and fragment parts, this would lead to authentication errors (401).

Fixes #137 馃

Unset `audience` will be take the URL as default value. When there are query and fragment parts, this would lead to authentication errors (401).
@ehsan-karamad ehsan-karamad requested review from averikitsch and a team as code owners July 20, 2021 13:53
@ehsan-karamad ehsan-karamad requested review from dandhlee and removed request for a team July 20, 2021 13:53
@product-auto-label product-auto-label bot added the api: cloudtasks Issues related to the googleapis/python-tasks API. label Jul 20, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 20, 2021
@ehsan-karamad ehsan-karamad changed the title Add explicit `audience1 field Add explicit audience field Jul 20, 2021
@ehsan-karamad ehsan-karamad marked this pull request as draft July 20, 2021 14:30
feat: Set `audience` in authenticated HTTP task

Unset `audience` will be take the URL as default value. When there are query and fragment parts, this would lead to authentication errors (401).
@ehsan-karamad ehsan-karamad marked this pull request as ready for review July 20, 2021 14:51
@ehsan-karamad ehsan-karamad changed the title Add explicit audience field feat: Setaudiencefield in authenticated HTTP task example Jul 20, 2021
@ehsan-karamad ehsan-karamad changed the title feat: Setaudiencefield in authenticated HTTP task example feat: Set audience field in authenticated HTTP task example Jul 20, 2021
@averikitsch averikitsch added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 20, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 20, 2021
Unset `audience` will be take the URL as default value. When there are query and fragment parts, this would lead to authentication errors (401).
@averikitsch averikitsch added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 21, 2021
@averikitsch averikitsch removed the request for review from dandhlee July 21, 2021 17:07
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 21, 2021
@averikitsch averikitsch merged commit 7a5a0c6 into googleapis:master Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: cloudtasks Issues related to the googleapis/python-tasks API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Authenticated (OIDC) HTTP task example should set an audience field
3 participants