Skip to content
Permalink
Browse files
fix: address PR comments
  • Loading branch information
busunkim96 committed May 20, 2020
1 parent 40ac7f3 commit 65f903b00395716fad272ca4fc973755735e1e20
Showing with 15 additions and 30 deletions.
  1. +1 −28 .kokoro/samples/python3.6/presubmit.cfg
  2. +1 −1 CODEOWNERS
  3. +13 −1 scripts/readme-gen/templates/README.tmpl.rst
@@ -1,33 +1,6 @@
# Format: //devtools/kokoro/config/proto/build.proto

# Build logs will be here
action {
define_artifacts {
regex: "**/*sponge_log.xml"
}
}

env_vars: {
key: "INSTALL_LIBRARY_FROM_SOURCE"
value: "True"
}

env_vars: {
key: "TRAMPOLINE_BUILD_FILE"
value: "github/python-texttospeech/.kokoro/test-samples.sh"
}

# Configure the docker image for kokoro-trampoline.
env_vars: {
key: "TRAMPOLINE_IMAGE"
value: "gcr.io/cloud-devrel-kokoro-resources/python-samples-testing-docker"
}

# Download secrets for samples
gfile_resources: "/bigstore/cloud-devrel-kokoro-resources/python-docs-samples"

# Download trampoline resources.
gfile_resources: "/bigstore/cloud-devrel-kokoro-resources/trampoline"

# Use the trampoline script to run in docker.
build_file: "python-texttospeech/.kokoro/trampoline.sh"
}
@@ -8,4 +8,4 @@
# The python-samples-owners team is the default owner for samples
* @googleapis/python-samples-owners

/samples/ @nnegrey @telpirion @sirtorry @googleapis/python-samples-owners
/samples/ @telpirion @sirtorry @googleapis/python-samples-owners
@@ -15,6 +15,16 @@ This directory contains samples for {{product.name}}. {{product.description}}

.. _{{product.name}}: {{product.url}}
{% if required_api_url %}
To run the sample, you need to enable the API at: {{required_api_url}}
{% endif %}

{% if required_role %}
To run the sample, you need to have `{{required_role}}` role.
{% endif %}

{{other_required_steps}}

{% if setup %}
Setup
-------------------------------------------------------------------------------
@@ -34,8 +44,10 @@ Samples
{{sample.name}}
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

{% if not sample.hide_cloudshell_button %}
.. image:: https://gstatic.com/cloudssh/images/open-btn.png
:target: https://console.cloud.google.com/cloudshell/open?git_repo=https://github.com/GoogleCloudPlatform/python-docs-samples&page=editor&open_in_editor={{folder}}/{{sample.file}},{{folder}}/README.rst
{% endif %}


{{sample.description}}
@@ -72,4 +84,4 @@ to `browse the source`_ and `report issues`_.

{% endif %}

.. _Google Cloud SDK: https://cloud.google.com/sdk/
.. _Google Cloud SDK: https://cloud.google.com/sdk/

0 comments on commit 65f903b

Please sign in to comment.