Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: incorporate upstream changes #73

Merged
merged 4 commits into from Jul 31, 2020
Merged

Conversation

@tmatsuo
Copy link
Member

@tmatsuo tmatsuo commented Jul 31, 2020

  • feat: Support MULAW audio encoding
  • feat: Support MP3_64_KBPS audio encoding
  • feat: Support timepointing via SSML tag
  • feat: Support quota_project_id
  • docs: generate and upload docfx yaml files
  • testing: add docs-presubmit build

Upstream change:
googleapis/googleapis@a94df49

@tmatsuo tmatsuo requested review from sirtorry, telpirion and as code owners Jul 31, 2020
@tmatsuo tmatsuo requested review from kurtisvg and removed request for Jul 31, 2020
@google-cla google-cla bot added the cla: yes label Jul 31, 2020
get supported "en-\*" voices; when specifying "no", you
will get supported "no-\*" (Norwegian) and "nb-*"
get supported "en-*" voices; when specifying "no", you
will get supported "no-*" (Norwegian) and "nb-*"
(Norwegian Bokmal) voices; specifying "zh" will also get
supported "cmn-*" voices; specifying "zh-hk" will also
get supported "yue-\*" voices.
get supported "yue-*" voices.
Copy link
Collaborator

@busunkim96 busunkim96 Jul 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why the synth replace isn't working for this, but this is the reason for the docs failure.

Loading

Copy link
Member Author

@tmatsuo tmatsuo Jul 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loading

Copy link
Member Author

@tmatsuo tmatsuo Jul 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I figured it out:

-    "((en)|(no)|(nb)(cmn)|(yue))-\*",
+    "((en)|(no)|(nb)|(cmn)|(yue))-\*",

Loading

Copy link
Member Author

@tmatsuo tmatsuo Jul 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it's green!

Loading

Copy link
Collaborator

@busunkim96 busunkim96 Jul 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woo! Thank you! 😁

Loading

@tmatsuo tmatsuo force-pushed the manual-synth branch 2 times, most recently from 8e83840 to d7258d8 Jul 31, 2020
@busunkim96 busunkim96 closed this Jul 31, 2020
@busunkim96 busunkim96 reopened this Jul 31, 2020
@tmatsuo tmatsuo removed the automerge label Jul 31, 2020
@tmatsuo
Copy link
Member Author

@tmatsuo tmatsuo commented Jul 31, 2020

We can merge this, but isn't it better to have autosynth do the job? It'll have a better changelig I think.

Loading

@tmatsuo
Copy link
Member Author

@tmatsuo tmatsuo commented Jul 31, 2020

I'm open to merge this, but in that case, let's have a better commit logs and PR description.

Loading

@tmatsuo tmatsuo changed the title testing: manually running synthtool feat: incorporate upstream changes Jul 31, 2020
@tmatsuo
Copy link
Member Author

@tmatsuo tmatsuo commented Jul 31, 2020

@busunkim96 I updated the PR title and description. How does it look?

Loading

Copy link
Collaborator

@busunkim96 busunkim96 left a comment

@tmatsuo, could you bump these two dependencies in setup.py? They are needed for some of the new changes in this PR.

'google-api-core[grpc] >= 1.22.0, < 2.0.0dev',

'proto-plus >= 1.4.0',

Loading

@tmatsuo
Copy link
Member Author

@tmatsuo tmatsuo commented Jul 31, 2020

I added feat: Support quota_project_id in the description. I think we should put those bullets into the commit log when we squash and merge.

Loading

@tmatsuo tmatsuo merged commit 8ee5447 into googleapis:master Jul 31, 2020
8 checks passed
Loading
@tmatsuo tmatsuo deleted the manual-synth branch Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants