Skip to content
This repository was archived by the owner on Feb 13, 2024. It is now read-only.

feat!: migrate to use microgen - #52

Merged
arithmetic1728 merged 4 commits into
masterfrom
sijun
Sep 29, 2020
Merged

feat!: migrate to use microgen#52
arithmetic1728 merged 4 commits into
masterfrom
sijun

Conversation

@arithmetic1728

@arithmetic1728 arithmetic1728 commented Sep 22, 2020

Copy link
Copy Markdown
Contributor

Handwritten layer changes:
(1) google/cloud/vision_helpers/__init__.py: https://github.com/googleapis/python-vision/pull/52/files#diff-0fe929b13ddc6cf4577dc0d6f0048519
(2) google/cloud/vision_helpers/decorators.py: https://github.com/googleapis/python-vision/pull/52/files#diff-35a1f6af0c72e84a1bfb2c4f32b1a7b9
(3) synth.py

@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 22, 2020
@product-auto-label product-auto-label Bot added the api: vision Issues related to the googleapis/python-vision API. label Sep 23, 2020
@arithmetic1728
arithmetic1728 marked this pull request as ready for review September 24, 2020 21:39
@arithmetic1728
arithmetic1728 requested review from busunkim96, engelke and software-dov and removed request for a team September 24, 2020 21:39
Comment thread google/cloud/vision_helpers/__init__.py Outdated
Comment thread google/cloud/vision_helpers/__init__.py Outdated
Comment thread google/cloud/vision_helpers/__init__.py Outdated
Comment thread google/cloud/vision_helpers/decorators.py Outdated
@arithmetic1728
arithmetic1728 requested a review from a team September 28, 2020 22:25
@arithmetic1728
arithmetic1728 merged commit cf3d353 into master Sep 29, 2020
@arithmetic1728
arithmetic1728 deleted the sijun branch September 29, 2020 18:49
@release-please release-please Bot mentioned this pull request Sep 29, 2020
@TurnrDev

Copy link
Copy Markdown

If this is a breaking change, what do I have to do to migrate my code? I swear this repo has the worst documentation.

@software-dov

Copy link
Copy Markdown

Take a look at UPGRADING.md

@busunkim96

busunkim96 commented Sep 30, 2020

Copy link
Copy Markdown
Contributor

@TurnrDev There is a migration guide in the published reference documentation which is linked in the README under "Client Library Documentation".

https://googleapis.dev/python/vision/latest/UPGRADING.html

It may also be helpful to look at the samples https://github.com/googleapis/python-vision/tree/master/samples/snippets

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: vision Issues related to the googleapis/python-vision API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants