Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: migrate to use microgen #52

Merged
merged 4 commits into from Sep 29, 2020
Merged

feat!: migrate to use microgen #52

merged 4 commits into from Sep 29, 2020

Conversation

@arithmetic1728
Copy link
Contributor

@arithmetic1728 arithmetic1728 commented Sep 22, 2020

Handwritten layer changes:
(1) google/cloud/vision_helpers/__init__.py: https://github.com/googleapis/python-vision/pull/52/files#diff-0fe929b13ddc6cf4577dc0d6f0048519
(2) google/cloud/vision_helpers/decorators.py: https://github.com/googleapis/python-vision/pull/52/files#diff-35a1f6af0c72e84a1bfb2c4f32b1a7b9
(3) synth.py

@arithmetic1728 arithmetic1728 marked this pull request as ready for review Sep 24, 2020
@arithmetic1728 arithmetic1728 requested review from engelke, busunkim96 and software-dov and removed request for Sep 24, 2020
google/cloud/vision_helpers/__init__.py Outdated Show resolved Hide resolved
Loading
google/cloud/vision_helpers/__init__.py Outdated Show resolved Hide resolved
Loading
google/cloud/vision_helpers/__init__.py Outdated Show resolved Hide resolved
Loading
google/cloud/vision_helpers/decorators.py Outdated Show resolved Hide resolved
Loading
@arithmetic1728 arithmetic1728 requested a review from as a code owner Sep 28, 2020
@arithmetic1728 arithmetic1728 merged commit cf3d353 into master Sep 29, 2020
8 checks passed
Loading
@arithmetic1728 arithmetic1728 deleted the sijun branch Sep 29, 2020
@release-please release-please bot mentioned this pull request Sep 29, 2020
@TurnrDev
Copy link

@TurnrDev TurnrDev commented Sep 30, 2020

If this is a breaking change, what do I have to do to migrate my code? I swear this repo has the worst documentation.

Loading

@software-dov
Copy link

@software-dov software-dov commented Sep 30, 2020

Take a look at UPGRADING.md

Loading

@busunkim96
Copy link
Collaborator

@busunkim96 busunkim96 commented Sep 30, 2020

@TurnrDev There is a migration guide in the published reference documentation which is linked in the README under "Client Library Documentation".

https://googleapis.dev/python/vision/latest/UPGRADING.html

It may also be helpful to look at the samples https://github.com/googleapis/python-vision/tree/master/samples/snippets

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants